Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/equivalent messages #5786

Draft
wants to merge 592 commits into
base: feat/consensus-size-changes
Choose a base branch
from
Draft

Feat/equivalent messages #5786

wants to merge 592 commits into from

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Dec 21, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.23326% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 80.37%. Comparing base (9fd067f) to head (d418058).

Files Patch % Lines
consensus/spos/bls/subroundBlock.go 60.16% 34 Missing and 15 partials ⚠️
consensus/spos/bls/subroundSignature.go 86.36% 6 Missing and 3 partials ⚠️
consensus/spos/consensusMessageValidator.go 82.60% 2 Missing and 2 partials ⚠️
.../block/interceptedBlocks/interceptedBlockHeader.go 80.00% 2 Missing and 2 partials ⚠️
consensus/spos/worker.go 97.02% 2 Missing and 1 partial ⚠️
consensus/spos/debug/equivalentMessagesDebugger.go 94.73% 1 Missing and 1 partial ⚠️
...ck/interceptedBlocks/interceptedMetaBlockHeader.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                       Coverage Diff                       @@
##           feat/consensus-size-changes    #5786      +/-   ##
===============================================================
+ Coverage                        80.29%   80.37%   +0.07%     
===============================================================
  Files                              712      713       +1     
  Lines                            94365    94688     +323     
===============================================================
+ Hits                             75775    76105     +330     
+ Misses                           13286    13267      -19     
- Partials                          5304     5316      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ilincaseby and others added 28 commits September 13, 2024 12:26
@ilincaseby
Removed pointer when calling function for initiating SubroundEndRound.
ebb8b72
@ilincaseby
Moved test error into a separate file of package bls_test.
473bba9
@ilincaseby
Put test error into the function and removed the file errors_test.go.
6631b4f
@cristure
added test for processing message.
aaa9d4b
@ssd04
fixes after review: removed equivalent messages handling from worker
41cf564
@sstanculeanu
Merge branch 'feat/equivalent-messages' into header_broadcast_on_comm…
2b78568 
…on_topic
@ssd04
Merge branch 'feat/equivalent-messages' into refactor-single-multi-key
2f08abe
@ssd04
fix factory and integration tests
2a6e05b
@ssd04
fix linter issues
340b17f
@ssd04
fix arguments in tests
48cd21d
@ssd04
fix peer shard resolver mock
2ed3b1a
@AdoAdoAdo
Merge pull request #6408 from multiversx/refactor-single-multi-key
6e8b0bc 
refactor to use common functions for single/multi-key
@sstanculeanu
Merge branch 'feat/equivalent-messages' into equivalent_proofs_interc…
c97c852 
…eptor
@sstanculeanu
Merge branch 'feat/equivalent-messages' into header_broadcast_on_comm…
f0ed35b 
…on_topic
@ilincaseby
Refactor error name.
b9ac52c
@ilincaseby
Refactor error name.
0b8bb75
@sstanculeanu
Merge branch 'feat/equivalent-messages' into benchmark_signature_veri…
a37a2ae 
…fication
@cristure
added message validation cache.
603bd69
@cristure
fix some tests.
57f009e
@AdoAdoAdo
Merge pull request #6424 from multiversx/benchmark_signature_verifica…
7c71f27 
…tion

benchmark_signature_verification
@sstanculeanu
Merge branch 'feat/equivalent-messages' into header_broadcast_on_comm…
7cb6795 
…on_topic
@sstanculeanu
Merge branch 'feat/equivalent-messages' into equivalent_proofs_interc…
26d4940 
…eptor
@sstanculeanu
fix after review
e92f7a8
@cristure
fixed missing topic.
f5a6f2e
@cristure
fix some more tests.
8eec330
@cristure
fix nil pointer dereferences in tests.
a733097
@cristure
more tests fixed.
bab3b05
@cristure
add map for cacher in more unit tests.
c3f7120
AdoAdoAdo and others added 30 commits December 11, 2024 10:51
@AdoAdoAdo
fixes proof checks in consensus message
a8e7a8e
@AdoAdoAdo
Merge pull request #6659 from multiversx/fix_header_verification
d0ec90f 
Fix header verification after equivalent proofs
@AdoAdoAdo
fixes proofs nil checks
93f1a71
@AdoAdoAdo
Merge branch 'feat/equivalent-messages' into fixes-header-sig-verific…
d663d3c 
…ation
@AdoAdoAdo
fixes proof verification - use correct consensus group
1e09723
@AdoAdoAdo
Merge branch 'fixes-header-sig-verification' of github.com:multiversx…
071f008 
…/mx-chain-go into fixes-header-sig-verification
@AdoAdoAdo
fix linter
18bc9c0
@AdoAdoAdo
fixes unit tests
8528bf2
@AdoAdoAdo
fixes unit tests for new checks
6228e44
@AdoAdoAdo
add flag check for proof verification
ca5f851
@AdoAdoAdo
add consensus header interceptor check for v1
9724125
@ssd04
Merge branch 'feat/equivalent-messages' into integrate-proof-check-on…
dd70b0d 
…-sync
@AdoAdoAdo
fixes after review
893302e
@ssd04
Merge pull request #6665 from multiversx/fixes-header-sig-verification
d7089a9 
Fixes header sig verification
@ssd04
Merge branch 'feat/equivalent-messages' into integrate-proof-check-on…
1715ed0 
…-sync
@ssd04
fix conflicts
8a95e05
@ssd04
added flag for proofs check in header intercetor
89a246e
@ssd04
remove todo in sync process for proofs
cb82037
@ssd04
remove accumulation maps for epoch start confirmation block
87a635e
@ssd04
rename chan
44ab7fa
@ssd04
more fixes after review
555ea3d
@ssd04
added more unit tests on handling equivalent proofs on sync
ebb3fc3
@ssd04
check for already existing equivalent proof
39af8f1
@sstanculeanu
Merge pull request #6501 from multiversx/integrate-proof-check-on-sync
7b02128 
Integrate proof check on sync
@ssd04
subround endround fixes
5b4a098
@ssd04
nil proof check in worker
537eb34
@ssd04
remove debug logs
2f56ebd
@ssd04
return true if subround already finished
f9527f6
@ssd04
remove extra empty line
5d2773f
@AdoAdoAdo
Merge pull request #6683 from multiversx/subround-endround-v2-fixes
7e35a87 
Subround endround v2 fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sstanculeanu sstanculeanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sstanculeanu @ilincaseby @cristure @ssd04 @AdoAdoAdo